Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Feature Failure: aws_spot_instance_request destroy #9920

Closed
EntilZha opened this issue Nov 7, 2016 · 4 comments · Fixed by #9968
Closed

Experimental Feature Failure: aws_spot_instance_request destroy #9920

EntilZha opened this issue Nov 7, 2016 · 4 comments · Fixed by #9968
Assignees

Comments

@EntilZha
Copy link

EntilZha commented Nov 7, 2016

Terraform told me to report this, so here it is.

Terraform version: 0.7.9

Affected Resource(s)

  • aws_spot_instance_request

Terraform Configuration Files

File used is at: https://github.com/Pinafore/qb/blob/master/aws.tf

Debug Output

Experimental feature failure! Please report a bug.

This is not an error. Your Terraform operation completed successfully.
Your real infrastructure is unaffected by this message.

While running, Terraform sometimes tests experimental features in the
background. These features cannot affect real state and never touch
real infrastructure. If the features work properly, you see nothing.
If the features fail, this message appears.

The following failures happened while running experimental features.
Please report a Terraform bug so that future Terraform versions that
enable these features can be improved!

You can report an issue at: https://github.com/hashicorp/terraform/issues

1 error(s) occurred:

* apply operation: Error building new graph: 1 error(s) occurred:

* Self reference: aws_spot_instance_request.master (destroy)

This is not an error. Your terraform operation completed successfully
and your real infrastructure is unaffected by this message.

Steps to Reproduce

  1. terraform apply
@mitchellh
Copy link
Contributor

Got it reproduced with this:

resource "null_resource" "foo" {
    provisioner "local-exec" {
        command = "echo ${null_resource.foo.id}"
    }
}

Steps:

  1. terraform apply
  2. terraform destroy -force

@mitchellh mitchellh self-assigned this Nov 8, 2016
mitchellh added a commit that referenced this issue Nov 8, 2016
Fixes #9920

This was an issue caught with the shadow graph. Self references in
provisioners were causing a self-edge on destroy apply graphs.

We need to explicitly check that we're not creating an edge to ourself.
This is also how the reference transformer works.
@mitchellh
Copy link
Contributor

I have a fix in the referenced PR. Thanks so much!

@EntilZha
Copy link
Author

EntilZha commented Nov 8, 2016

NP, terraform is a great piece of software that has helped speed up the pace of our research!

gusmat pushed a commit to gusmat/terraform that referenced this issue Dec 6, 2016
Fixes hashicorp#9920

This was an issue caught with the shadow graph. Self references in
provisioners were causing a self-edge on destroy apply graphs.

We need to explicitly check that we're not creating an edge to ourself.
This is also how the reference transformer works.
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants