Feature gcp region autoscaler

[corianderpulm]

Ready for review! Previously it had the WIP tag but it was finished, only requiring a quick review.

Note: The new resource 'google_compute_region_autoscaler' was created to work with the 'google_compute_region_instance_group_manager' resource introduced in PR #10907.

I noticed the normal Google Cloud autoscaler requires a 'zone' variable. For region level autoscalers this should not be required as it crosses zones. Trying to create an autoscaler set in one zone fails as the logic inside the plugin itself is looking the autoscaler up by zone and name instead of region and name. While this is useful for single-zone autoscalers, it conflicts with how they work on a cross-zone basis. This PR is a lightly modified 'compute_autoscaler' resource that has explicit logic for region instance group managers.

[corianderpulm]

Be advised, this is kind of a weird PR as it requires #10907 to be also merged in so CI tests might fail.

[Pryz]

Any update on this ?

[apparentlymart]

Hi @CoryPulm!

Sorry this wasn't reviewed before. At the time you submitted this we were starting the process of splitting the provider code out into separate repositories, so the Google Cloud provider now has its own repository and its own team of maintainers.

This change unfortunately isn't mergable as-is because the rest of the provider code isn't here anymore. With that said, it looks like there is a google_compute_region_autoscaler resource that was added in hashicorp/terraform-provider-google#544 which I assume exposes the same underlying APIs as what was added here, so I'm going to close this.

Thanks for working on this @CoryPulm, and sorry it got caught up in the confusion while the providers were being migrated.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.