-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement "openstack_networking_port_v2" resource #1789
Conversation
d824616
to
3f32fc6
Compare
@JeanMertz Are you running |
This LGTM. Let me know when you can get the tests passing. |
@catsby this issue could use a provider/openstack label... |
@mitchellh thanks for the heads up. I was under the impression that the I'll work on the tests this weekend so this can be pulled. |
@JeanMertz If you're interested, here's a Terraform configuration and build script to build out a devstack environment and run the suite of acceptance tests. You can tweak it as needed. |
@JeanMertz did you ever get tests working? anything you need to finish this out? |
Closing in favor of #3731. @JeanMertz's original commit is still included 😄 |
Sorry for letting this linger guys. Awesome to see it getting picked up to the finish line 👍 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
A couple of notes:
_test.go
files, and rungo test ./...
, all tests still pass. As soon as I manage to get a test-workflow going, I will try my hand at the tests.mac_address
value is "updated" on every run, if left unspecified. This is something I also mentioned in OpenStack: plan always shows changes to resource #1784 but I am unsure if it is a fault of my usage of Terraform, or the implementation.