Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "openstack_networking_port_v2" resource #1789

Closed

Conversation

JeanMertz
Copy link
Contributor

A couple of notes:

  • I didn't write any tests, because I apparently can't even break any tests. Whenever I change random test values in _test.go files, and run go test ./..., all tests still pass. As soon as I manage to get a test-workflow going, I will try my hand at the tests.
  • I tested this on my own OpenStack environment, and things work as expected.
  • It seems the resource mac_address value is "updated" on every run, if left unspecified. This is something I also mentioned in OpenStack: plan always shows changes to resource #1784 but I am unsure if it is a fault of my usage of Terraform, or the implementation.

@mitchellh
Copy link
Contributor

@JeanMertz Are you running make testacc? go test will not run acceptance tests.

@mitchellh
Copy link
Contributor

This LGTM. Let me know when you can get the tests passing.

@dupuy
Copy link
Contributor

dupuy commented May 6, 2015

@catsby this issue could use a provider/openstack label...

@JeanMertz
Copy link
Contributor Author

@mitchellh thanks for the heads up. I was under the impression that the _test.go files where unit-tests. I guess I didn't look at them thoroughly.

I'll work on the tests this weekend so this can be pulled.

@jtopjian
Copy link
Contributor

@JeanMertz If you're interested, here's a Terraform configuration and build script to build out a devstack environment and run the suite of acceptance tests. You can tweak it as needed.

@josephholsten
Copy link
Contributor

@JeanMertz did you ever get tests working? anything you need to finish this out?

@jtopjian
Copy link
Contributor

jtopjian commented Nov 3, 2015

Closing in favor of #3731. @JeanMertz's original commit is still included 😄

@jtopjian jtopjian closed this Nov 3, 2015
@JeanMertz
Copy link
Contributor Author

Sorry for letting this linger guys. Awesome to see it getting picked up to the finish line 👍

@JeanMertz JeanMertz deleted the openstack-networking-ports branch November 3, 2015 22:15
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants