Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add AutoMinorVersionUpgrade to RDS. #2637

Closed
wants to merge 1 commit into from
Closed

provider/aws: Add AutoMinorVersionUpgrade to RDS. #2637

wants to merge 1 commit into from

Conversation

matsuzj
Copy link
Contributor

@matsuzj matsuzj commented Jul 7, 2015

Setting of AutoMinorVersionUpgrade was put in, but setting didn't become effective.
It was changed so that AutoMinorVersionUpgrade might become effective.

@matsuzj matsuzj changed the title provider/aws: Support of AutoMinorVersionUpgrade was put in RDS. provider/aws: Add AutoMinorVersionUpgrade to RDS. Jul 20, 2015
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 4 times, most recently from 726a67f to 75eb6eb Compare July 24, 2015 11:12
catsby
catsby reviewed Jul 24, 2015
View reviewed changes
builtin/providers/aws/resource_aws_db_instance.go
Engine: aws.String(d.Get("engine").(string)),
EngineVersion: aws.String(d.Get("engine_version").(string)),
StorageEncrypted: aws.Boolean(d.Get("storage_encrypted").(bool)),
AutoMinorVersionUpgrade: aws.Boolean(d.Get("auto_minor_version_upgrade").(bool)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default for this value is true, according to the API:

I think we need to add Default: true to the schema block, replacing Computed: false, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would like to upgrade MinorVersionUpgrade manually.
When it can be chosen, they should be happy.

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Jul 24, 2015
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 5 times, most recently from ee95d87 to 0ba0dac Compare July 29, 2015 02:35
@catsby catsby removed the waiting-response An issue/pull request is waiting for a response from the community label Jul 29, 2015
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 6 times, most recently from feab32c to ef824b9 Compare August 5, 2015 23:21
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 4 times, most recently from 8fc861f to da19fff Compare August 13, 2015 03:40
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 3 times, most recently from 7edd666 to 256ab6d Compare August 21, 2015 02:24
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 2 times, most recently from 27294f6 to 1501048 Compare August 31, 2015 23:34
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 2 times, most recently from 4fdba9b to 9b226a0 Compare September 13, 2015 07:43
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch from 9b226a0 to c4c4489 Compare September 14, 2015 07:58
@josephholsten
Copy link
Contributor

diff sans whitespace: https://github.com/hashicorp/terraform/pull/2637/files?w=1

@phinze ready for your 👀

@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch from c4c4489 to 9c92480 Compare September 30, 2015 08:02
@catsby
Copy link
Contributor

catsby commented Oct 2, 2015

AutoMinorVersionUpgrade defaults to true on AWS:

If the user does not specify this attribute in the config, is this default maintained? I wonder if d.Get("auto_minor_version_upgrade").(bool) returns false if the attribute is not specified

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Oct 2, 2015
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 2 times, most recently from 7b19c5d to b52ca47 Compare October 4, 2015 04:39
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch 2 times, most recently from ea85877 to 5e896f4 Compare October 15, 2015 02:19
@matsuzj matsuzj force-pushed the f-aws-rds-suport-auto-minor-version-upgrade branch from 5e896f4 to 274e2a1 Compare October 20, 2015 08:05
@catsby catsby mentioned this pull request Oct 28, 2015
Merged
@catsby
Copy link
Contributor

catsby commented Oct 28, 2015

Thanks for the work here @matsuzj! I'm continuing the work on #3677 so I'm going to close this. Thanks again!

@catsby catsby closed this Oct 28, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matsuzj @josephholsten @catsby @radeksimko