Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring for ignore-remote-version #27611

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Jan 27, 2021

Update docstring for ignore-remote-version to be more accurate, as it's not whether the versions differ, but if they are incompatible

Update docstring for ignore-remote-version to be more accurate,
as it's not whether the versions differ, but if they are incompatible
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #27611 (c1ede28) into master (1a16ce8) will increase coverage by 0.00%.
The diff coverage is 42.85%.

Impacted Files Coverage Δ
command/state_rm.go 46.93% <0.00%> (ø)
command/taint.go 38.18% <0.00%> (ø)
command/untaint.go 37.50% <0.00%> (ø)
command/import.go 53.14% <33.33%> (ø)
command/meta.go 77.15% <100.00%> (ø)
command/state_mv.go 55.87% <100.00%> (ø)
command/state_replace_provider.go 77.77% <100.00%> (ø)
dag/marshal.go 61.90% <0.00%> (-1.59%) ⬇️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@pselle pselle requested a review from a team January 27, 2021 20:55
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@pselle pselle merged commit 29dd334 into master Jan 27, 2021
@pselle pselle deleted the pselle/ignore-remote-version-docstring branch January 27, 2021 21:59
@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants