Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstreamed HCL typexpr package #31729

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

alisdair
Copy link
Contributor

@alisdair alisdair commented Sep 1, 2022

The 2.14.0 release of HCL includes the typeexpr changes we tested here, so now we can revert to using the HCL package and remove our fork.

@alisdair alisdair added the 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Sep 1, 2022
@alisdair alisdair requested a review from a team September 1, 2022 20:01
@alisdair alisdair self-assigned this Sep 1, 2022
The 2.14.0 release of HCL includes the typeexpr changes we tested here,
so now we can revert to using the HCL package and remove our fork.
@alisdair alisdair merged commit bce43fa into main Sep 2, 2022
@alisdair alisdair deleted the alisdair/typeexpr-upstreamed branch September 2, 2022 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants