Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: terraform providers mirror command should honor terraform lock file #32742

Conversation

rkhaled0
Copy link
Contributor

When mirroring providers using terraform providers mirror command, AND, if dependency lock file exists, selected provider version might not match the dependency lock file.

So, this PR addresses this issue by honouring the lock file if present.

A new e2e test case has been added to cover this new case.

Fixes #28274

Target Release

1.3.x

Draft CHANGELOG entry

BUG FIXES

  • terraform providers mirror: support dependency lock file

@rkhaled0 rkhaled0 force-pushed the bugfix/issue-28274-providers-mirroring-honor-lockfile branch from 265652a to 100c44b Compare February 24, 2023 23:16
@rkhaled0 rkhaled0 marked this pull request as ready for review February 24, 2023 23:24
@rkhaled0
Copy link
Contributor Author

Hi @alisdair ,

Please find here changes about supporting dependency lock file when mirroring providers.

Notice that race tests have failed but I'm not sure if its related to my changes.

Thanks for your support.

@alisdair alisdair added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 27, 2023
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! This looks good to me. The race test failure was unrelated and a rerun here allowed it to pass.

I've marked this for release in the 1.4 series. We've just missed the 1.4.0 window (release candidate out now), but I'll propose that it's merged for 1.4.1. Thanks again!

@alisdair alisdair merged commit 7294083 into hashicorp:main Feb 27, 2023
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

providers mirror doesn't use lock file
2 participants