Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/s3: Supports S3 buckets with Object Lock #33940

Merged
merged 2 commits into from
Sep 26, 2023
Merged

backend/s3: Supports S3 buckets with Object Lock #33940

merged 2 commits into from
Sep 26, 2023

Conversation

gdavison
Copy link
Contributor

Enables checksum in PutObject and UploadPart requests to support S3 buckets with Object Lock enabled.

Fixes #23127

Target Release

1.6.0

Draft CHANGELOG entry

BUG FIXES

  • S3 Backend: Fixes error when storing state in S3 buckets with Object Locks enabled

@gdavison gdavison added bug backend/s3 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Sep 25, 2023
@gdavison gdavison requested a review from a team as a code owner September 25, 2023 21:25
@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 26, 2023 •
edited
Loading

Addressed in the Terraform AWS Provider AWS SDK for Go v2 migration via hashicorp/terraform-provider-aws#33358.

jar-b
jar-b approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪣

% TF_ACC=1 go test ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 139.561s

internal/backend/remote-state/s3/client.go Show resolved Hide resolved
@gdavison gdavison merged commit 6066326 into main Sep 26, 2023
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Sep 26, 2023
Merged
@gdavison gdavison deleted the s3/b-put-with-object-locks branch September 26, 2023 19:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s3 backend cannot write state to buckets with mandatory object lock
3 participants
@gdavison @ewbankkit @jar-b