Validate self-references within resource count and foreach arguments

[liamcervante]

Currently Terraform will crash if a resource references itself from the count or for_each attributes. This PR updates the expansion node for resources to perform the same check that the execution nodes perform based on "self-references. After this PR, Terraform reports a consistent error if any attributes from within a resource reference that same resource.

Fixes #35038

Target Release

1.8.2

Draft CHANGELOG entry

ENHANCEMENTS

• Replace panic with error message when self-referencing resources and data source from the count or for_each meta attributes.

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.