provider/aws: Fix issue with retrying deletion of Network ACLs

[catsby]

Fix retry after removing associations by correctly checking and returning an
error. This should patch the VPC/Resource leak in our nightly acceptance tests.

In addition, I've added tags to each of the VPCs created in each test, so that we can identify future leaks with greater ease. There is some overlap (one test may re-use a config), but we'll still narrow it down the what test file it came from

[jen20]

LGTM

[phinze]

👍

[Nalum]

Is there a planned release date for this?

[brikis98]

Did this get released? I just hit the same "The vpc 'vpc-xxx' has dependencies and cannot be deleted" error with Terraform v0.6.16 on a VPC with network ACLs.

[catsby]

@brikis98 this should have gone out with v0.6.15.

"The vpc 'vpc-xxx' has dependencies and cannot be deleted" error with Terraform v0.6.16 on a VPC with network ACLs.

This can be a legitimate error. Do you have a sample configuration that demonstrates this as a Terraform issue? I can look in

[brikis98]

@catsby The configuration that leads to this situation is fairly large and complicated. However, I suspect that what led to this situation was what I described in #7527: that is, trying to create Network ACLs before the Gateways are ready for the new VPC. This seems to completely break Terraform's state management and lead to all sorts of crazy errors, including the one in this issue.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.