provider/rundeck: Added multiple functionality.

[BobVanB]

Added multiple functionality: schedule, descriptions, storagepath, scriptinterpreter, nodesSelectedByDefault, scriptinterpreter, nodefilterbydefault

Terraform plan is now clean, so only changes you made are seen.

UseCase: Changeing all our manual rundeck code to terraform, and missing some features in the process.

Still waiting for pull request on go-rundeck-api:
apparentlymart/go-rundeck-api#9

[BobVanB]

Working code i currently use in production.

resource "rundeck_job" "my_job_name" {
  name = "My Job Name"
  description = "${file("${path.module}/scripts/description")}"
  project_name = "${rundeck_project.rundeck_project.name}"
  preserve_options_order = true

  node_filter_query = "${file("${path.module}/scripts/filter_query")}"
  max_thread_count = 10
  nodes_selected_by_default = true

  allow_concurrent_executions = false
  continue_on_error = false

  dispatch {
    continue_on_error = true
  }

  option {
    name = "Option"
    description = "${file("${path.module}/scripts/option_description")}"
    default_value = "status"
    value_choices = ["pulled","open","merged"]
    required = true
    require_predefined_choice = true
  }

  command {
    inline_script = "${file("${path.module}/scripts/inline_script")}"
    description = "Command Description"
  }
}

[apparentlymart]

Could we use a ValidateFunc on the schedule_cron attribute for this? If we do the validation there then Terraform can detect it during the "plan" step in some cases (as long as it doesn't contain any interpolation expressions).

[BobVanB]

I came back of my opinion, yes we can put MaxItems on the element, this will trigger the validation on the plan step.

[apparentlymart]

Thanks for this, @BobVanB!

I merged the upstream client library change, and I left an initial comment here for now, but generally this looks good so far. Let me know when you're done here, and if you need any help with the acceptance tests or docs.

[BobVanB]

@apparentlymart I will pick this up monday, thnx for the review.

[BobVanB]

Do you mean something like this?
#8103

[BobVanB]

Added documentation and an advanced acceptance test.

[BobVanB]

`

[BobVanB]

Schema has a MaxItems for List elements, will test en add this tomorrow.
This will validate the schema at plan setup.
Also added a deprication warning for exclude presedence.

[BobVanB]

@apparentlymart I think this one can be reviewed and is ready for merging.

[BobVanB]

I have another idea, but that has to be separate from this pull.
Write a wrapper around: https://github.com/asaskevich/govalidator
And put more validation in the schema.

[BobVanB]

I see that i dont have the latest go-rundeck-api version, updating it and then i will remove the wip

[BobVanB]

Currently adding errorhandling functionality.
If you have comments on changing keys, or other tips and stuff.
Just shout it out, there welcome and needed.
Else i am going to do what i think is easy. :D

[apparentlymart]

Hi @BobVanB!

I do intend to review this in more detail soon, but I just wanted to make a general note now: it seems like this patch is becoming quite a large set of changes, and the larger it gets the more complicated it will be to review. When possible it's preferable for each PR to add one specific feature so that it can be reviewed and merged in isolation from the rest.

I certainly don't want to discourage your momentum here, since there's some good stuff! Just want to make sure we can get this stuff merged efficiently, rather than going back and forth on many small details in a large patch.

[BobVanB]

Yeah I firgure that, was feeling the same.

The last one errorhandling changes alot of code.
I thing I should have put this seperatly.

Also still dont like that booleans are always present, there should be a third type for it "nil"
Omitempty an false can messup the plan output with unnessacary changes. But this will need an api change.

[BobVanB]

For now added yet another feature, ^^ have to wait for the api first :P
notification>email/webhook

[BobVanB]

@apparentlymart After i checken out the boolean bug. I will cut this one Into smaller party.

[BobVanB]

Splitting this merge into multiple merges. closing this one.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.