Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aws_sns_topic_subscription" add notes and examples for cross account… #9838

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

AndHei
Copy link
Contributor

@AndHei AndHei commented Nov 3, 2016

… / region SNS topic to SQS queue subscription

Based on #6909 and #5973 I suggest adding information to the documentation about cross account / region SNS topic to SQS queue subscription.

… / region SNS topic to SQS queue subscription

Based on hashicorp#6909 I suggest adding information to the documentation about cross account / region SNS topic to SQS queue subscription.
@stack72
Copy link
Contributor

stack72 commented Nov 3, 2016

LGTM! Nice addition to the docs :)

@stack72 stack72 merged commit 1929fe7 into hashicorp:master Nov 3, 2016
@stack72
Copy link
Contributor

stack72 commented Nov 3, 2016

@AndHei does this PR solve those other issues? It feels like they were not a code issue but a documentation issue - thoughts?

@AndHei
Copy link
Contributor Author

AndHei commented Nov 3, 2016

@stack72 my understanding is that #6909 and #5973 are rather documentation issues and not code issues.

gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
… / region SNS topic to SQS queue subscription (hashicorp#9838)

Based on hashicorp#6909 I suggest adding information to the documentation about cross account / region SNS topic to SQS queue subscription.
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants