Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-string query parameters #150

Merged
merged 2 commits into from
Apr 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api_auth.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions api_helpers.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package vault

import "fmt"

// parameterToString is a very simple function that returns the string
// representation of the given parameter value. We may need to expand this
// later to handle time.Time values, slices, etc.
func parameterToString(value interface{}) string {
return fmt.Sprintf("%v", value)
}
25 changes: 25 additions & 0 deletions api_helpers_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package vault

import (
"testing"

"github.com/stretchr/testify/require"
)

func Test_parameterToString(t *testing.T) {
cases := []struct {
value interface{}
expected string
}{
{value: false, expected: "false"},
{value: 12345, expected: "12345"},
{value: 12.45, expected: "12.45"},
{value: "str", expected: "str"},
}

for _, tc := range cases {
t.Run(tc.expected, func(t *testing.T) {
require.Equal(t, tc.expected, parameterToString(tc.value))
})
}
}
2 changes: 1 addition & 1 deletion api_identity.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions api_system.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generate/templates/api.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func ({{lower (substring classname 0 1)}} *{{cut classname "Api"}}) {{nickname}}

requestQueryParameters := make(url.Values){{#each queryParams}}{{#eq paramName "list"}}
requestQueryParameters.Set("{{paramName}}", "true"){{/eq}}{{#neq paramName "list"}}
requestQueryParameters.Set("{{paramName}}", url.QueryEscape({{paramName}})){{/neq}}{{/each}}
requestQueryParameters.Set("{{paramName}}", url.QueryEscape(parameterToString({{paramName}}))){{/neq}}{{/each}}

{{#each bodyParams}}
return sendStructuredRequestParseResponse[{{#with returnType}}schema.{{{.}}}{{/with}}{{#unless returnType}}map[string]interface{}{{/unless}}](
Expand Down