Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate /sys/health error checks #221

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Consolidate /sys/health error checks #221

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7795b60
Consolidate /sys/health error checks
averche Jul 28, 2023
91004de
Use switch instead of slices.Contains
averche Jul 30, 2023
69399d9
cleanup
averche Jul 30, 2023
c462cbc
fix build
averche Jul 30, 2023
0d22c5e
PR feedback
averche Sep 18, 2023
5762f9b
Merge branch 'main' into consolidate-if-checks
averche Sep 18, 2023
911910a
comment
averche Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
"io"
"net/http"
"strings"

"golang.org/x/exp/slices"
averche marked this conversation as resolved.
Show resolved Hide resolved
)

// IsErrorStatus returns true if the given error is either a ResponseError or a
Expand Down Expand Up @@ -55,17 +57,20 @@ func isResponseError(req *http.Request, resp *http.Response) *ResponseError {
return nil
}

// 429 is returned by standby instances for /sys/health requests and should
// not be treated as an error; for other paths the status code indicates
// that the quota limit has been reached.
if resp.StatusCode == http.StatusTooManyRequests /* 429 */ && req.URL.Path == "/v1/sys/health" {
return nil
// /v1/sys/health returns a few special 4xx status codes that should not be
// treated as errors:
//
// - 429 if unsealed and standby
// - 472 if disaster recovery mode replication secondary and active
// - 473 if performance standby
//
// See: https://developer.hashicorp.com/vault/api-docs/system/health
if req.URL.Path == "/v1/sys/health" {
switch resp.StatusCode {
case 429, 472, 473:
return nil
}
}
averche marked this conversation as resolved.
Show resolved Hide resolved

// 472 & 473 are returned by (performance/secondary) standby instances for /sys/health requests and should
// not be treated as an error
if (resp.StatusCode == 472 || resp.StatusCode == 473) && req.URL.Path == "/v1/sys/health" {
return nil
}

responseError := &ResponseError{
Expand Down