Flip default value for -write-secrets flag #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Jan 11, 2022
Comment on lines
+13
to
+14
| * Support for sending secret contents to driver for writing via `-write-secrets=false` [[GH-89](https://github.com/hashicorp/vault-csi-provider/pull/89)] | ||
| * **Note:** `-write-secrets=false` will become the default from v0.4.0 and require secrets-store-csi-driver v0.0.21+ |
There was a problem hiding this comment.
Did the flag format change from -- to -? Or were these just typos?
There was a problem hiding this comment.
Sorry I should have explained this change. With the standard lib "flag" package we're using, both forms work, but if you run with -help or --help, it prints the flags with a single dash, so I thought it would be better to be consistent on single dashes, which also matches better with the rest of our CLIs anyway.
| @if [ "$(shell kubectl get pods -n csi -l app.kubernetes.io/name=vault-csi-provider -o json | jq -r '.items[0].spec.containers[0].args[] | match("--write_secrets=(true|false)").captures[0].string')" = "false" ]; then\ | ||
| WRITE_SECRETS=true make e2e-set-write-secrets;\ | ||
| else\ | ||
| @if [ "$(shell kubectl get pods -n csi -l app.kubernetes.io/name=vault-csi-provider -o json | jq -r '.items[0].spec.containers[0].args[] | match("--write_secrets=(true|false)").captures[0].string')" = "true" ]; then\ |
There was a problem hiding this comment.
Does this need to be single-dash format here too? i.e. match("-write_secrets...
There was a problem hiding this comment.
Sorry I meant to push a commit addressing this before merging. Opened #129 to address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the upstream driver project, sending secret contents upstream for the driver to write to file needs to become the default. This gets rid of one of the
hostPathvolumes required in the default manifest, as the provider no longer needs to directly write to pods' mounts with this default.