Adds support to explicitly configure network policy in injector #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the conversion around PR hashicorp#381, network policies are useful for the injector independent of openshift. This allows support for those use cases but similarly will require some configuration changes for openshift users.
|
|
| @@ -1,4 +1,4 @@ | |||
| {{- if and (eq (.Values.injector.enabled | toString) "true" ) (and (eq (.Values.global.enabled | toString) "true") (eq (.Values.global.openshift | toString) "true") ) }} | |||
| {{- if eq (.Values.injector.networkPolicy.enabled | toString) "true" }} | |||
There was a problem hiding this comment.
I believe this would create a networkPolicy even if you disabled the injector, which shouldn't happen.
|
Bumping this 😄 |
|
I ran into some issues I didn't end up chasing down yet. I'll close this since I don't have immediately plans to revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the conversion around PR #381, network policies are useful for the injector independent of openshift. This allows support for those use cases but similarly will require some configuration changes for openshift users.