Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #304

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update dependencies #304

merged 1 commit into from
Oct 27, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 25, 2021

Pin go docker image to 1.17.2 to ensure more deterministic CI workflow.

Executed the injector acceptance test from https://github.com/hashicorp/vault-helm against an image with these updates:

make test-acceptance LOCAL_ACCEPTANCE_TESTS=true ACCEPTANCE_TESTS=acceptance/injector.bats
kind get clusters | grep -q "^vault-helm$" || \
        kind create cluster \
        --image kindest/node:v1.20.2 \
        --name vault-helm  \
        --config /Users/bash/src/github.com/hashicorp/vault-helm/test/kind/config.yaml
kubectl config use-context kind-vault-helm
Switched to context "kind-vault-helm".
bats test/acceptance/injector.bats
 ✓ injector: testing deployment

1 test, 0 failures

- pin go docker image to 1.17.2 to ensure more deterministic CI workflow.
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it a bit manually as well and all seems to work.

@benashz benashz merged commit 959a601 into main Oct 27, 2021
@benashz benashz deleted the update-deps branch October 27, 2021 21:07
RemcoBuddelmeijer pushed a commit to RemcoBuddelmeijer/vault-k8s that referenced this pull request Feb 22, 2022
- pin go docker image to 1.17.2 to ensure more deterministic CI workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants