Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the default alias names to role_id for both IAM and GCE authn #99

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

austingebauer
Copy link
Contributor

@austingebauer austingebauer commented Jul 16, 2020

Overview

This PR changes the default name of the entity alias that gets created for both IAM and GCE authentication. Test fixes are also included in this PR. See test output below.

For IAM, changes it from unique_id to role_id.
For GCE, change it from instance_id to role_id.

Docs PR: hashicorp/vault#9494

Design of Change

Change was implemented using alias configuration made available in #89.

Related Issues/Pull Requests

Contributor Checklist

  • Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
  • Backwards compatible
    • This is an intentional change that will be included in a CHANGES entry in the Vault CHANGELOG.
  • Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
$ export GOOGLE_CREDENTIALS="$(cat /Users/austingebauer/.gcp/austin-gebauer-db62ff1c96b4.json)"
$ make test                                                                                    
?       github.com/hashicorp/vault-plugin-auth-gcp      [no test files]
ok      github.com/hashicorp/vault-plugin-auth-gcp/plugin       (cached)
?       github.com/hashicorp/vault-plugin-auth-gcp/plugin/cache [no test files]
$ echo $?
0

pcman312
pcman312 previously approved these changes Jul 16, 2020
@austingebauer austingebauer merged commit ff9abb1 into master Jul 16, 2020
@austingebauer austingebauer deleted the change-default-aliases branch July 16, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants