attempts at testing

hashicorp · Aug 5, 2024 · 91ad11c · 91ad11c
1 parent d04d1b9
commit 91ad11c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/path_config.go b/path_config.go
@@ -397,7 +397,10 @@ func (b *jwtAuthBackend) createProvider(config *jwtConfig) (*oidc.Provider, erro
 			}
 			oids = append(oids, oid)
 		}
-		ietripper := httputil.NewIgnoreUnhandledExtensionsRoundTripper(b.Logger(), nil, oids)
+		ietripper, err := httputil.NewIgnoreUnhandledExtensionsRoundTripper(nil, oids)
+		if err != nil {
+			return nil, err
+		}
 		opts = append(opts, oidc.WithRoundTripper(ietripper))
 	}
 	c, err := oidc.NewConfig(config.OIDCDiscoveryURL, config.OIDCClientID,

diff --git a/path_login_test.go b/path_login_test.go
@@ -63,6 +63,10 @@ func setupBackend(t *testing.T, cfg testConfig) (closeableBackend, logical.Stora
 		data = map[string]interface{}{
 			"bound_issuer":       "https://team-vault.auth0.com/",
 			"oidc_discovery_url": "https://team-vault.auth0.com/",
+			"unsupported_critical_cert_extensions": []string{
+				"2.5.29.54",
+				"2.5.29.36",
+			},
 		}
 	} else {
 		if !cfg.jwks {

diff --git a/path_oidc_test.go b/path_oidc_test.go
@@ -41,6 +41,10 @@ func TestOIDC_AuthURL(t *testing.T) {
 		"oidc_client_secret":    "def",
 		"default_role":          "test",
 		"bound_issuer":          "http://vault.example.com/",
+		"unsupported_critical_cert_extensions": []string{
+			"2.5.29.54",
+			"2.5.29.36",
+		},
 	}
 
 	// basic configuration