Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #50

Closed

Conversation

shelby-moore
Copy link

No description provided.

@catsby
Copy link
Contributor

catsby commented Nov 29, 2018

Hey there! Thanks for doing this. Can you share what command you ran here? Seems all the digests were removed, and an import block was replaced with a digest. I'm not sure if this is a new dep format or something, just looking to verify 😄

@shelby-moore
Copy link
Author

I just ran dep ensure - let me know if I should run something else. Is it okay if I update the README to document what needs to be run to grab dependencies?

@catsby
Copy link
Contributor

catsby commented Nov 30, 2018

Hey @shelby-moore-hs - I suspect you may have used an older version of dep, ensure shouldn't change Gopkg.lock (pretty sure..). The changes there are telling too; removal of digest and input-imports, both added in dep 0.5 I think:

To save you more hassle, I went ahead and ran dep ensure with dep 0.5 and merged the results: #52

I'm going to close this, thanks!

For the rest:

  • If you can rebase your original PR, that would be awesome, but I'll totally understand if you'd rather me do it since I've already made you jump through enough hoops
  • Re: README, it's absolutely okay if you have the time 😄

@catsby catsby closed this Nov 30, 2018
@catsby
Copy link
Contributor

catsby commented Nov 30, 2018

Actually, I'm going to cherry-pick 4d5cc19 into a new PR to save you trouble, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants