Try reading the ca.crt and TokenReviewer JWT from the default service account #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eh-steve
requested review from
tyrannosaurus-becks and
briankassouf
and removed request for
tyrannosaurus-becks
… account secret location to support running inside k8s
eh-steve
force-pushed
the
ca-and-token-from-filesystem-if-empty
branch
from
cf350ad to
797fe07
Compare
eh-steve
changed the title
|
that would be amazing!!! |
|
@kalafut any chance this change can be considered to merge-in? |
|
@riuvshyn Yes, we'll be adding it soon. |
jasonodonnell
requested review from
jasonodonnell
and removed request for
tyrannosaurus-becks
|
I opened an issue that references this PR as the cause. I am unable to authenticate to external clusters (when vault is itself running in a cluster) due to the fact that in this change you default the tokenReviewerJWT to the POD token (if found) and one wasn't supplied in the auth configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help address #82