config: set default length only if password policy is missing #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue in the
config
endpoint where the defaultlength
value is always set regardless of whetherpassword_policy
is provided. This leads to configuration errors unlesslength=0
is explicitly provided.password_policy
andlength
are mutually exclusive, with preferred onpassword_policy
, so the engine should understand that the value is ignored and not necessary ifpassword_policy
is provided.Design of Change
We now parse the
password_policy
first, and fallback to fetchinglength
's default value if both the length and password_policy is absent. The change should be backwards compatible.Contributor Checklist
Note: Docs already describes this behavior, but the engine was not behaving as expected.