Merge b240a5a into backport/VAULT-26464/fix-update-resources-target/c…

…entrally-viable-crab

Makefile

@@ -68,11 +68,7 @@ fmt:
 
 .PHONY: update-resources
 update-resources:
-	pushd $(CURDIR)/plugin/iamutil && \
-	go build -o generate ./internal && \
-	./generate && \
-	rm generate && \
-	popd
+	go run ./plugin/iamutil/internal
 
 .PHONY: setup-env
 setup-env:

plugin/iamutil/internal/generate_resources.go

@@ -5,28 +5,40 @@ package main
 
 import (
 	"bytes"
+	"encoding/json"
 	"errors"
 	"fmt"
 	"go/format"
+	"io"
 	"log"
+	"net/http"
 	"net/url"
 	"os"
+	"path/filepath"
 	"regexp"
 	"strings"
 	"text/template"
 
-	"github.com/hashicorp/errwrap"
-	"github.com/hashicorp/go-cleanhttp"
-	"github.com/hashicorp/go-multierror"
-	"github.com/hashicorp/vault-plugin-secrets-gcp/plugin/iamutil"
 	"google.golang.org/api/discovery/v1"
+
+	"github.com/hashicorp/vault-plugin-secrets-gcp/plugin/iamutil"
 )
 
 const (
 	templateFile = "resource_config_template"
 	outputFile   = "resources_generated.go"
 )
 
+// allowedPolicyRefs lists all the possible $ref values
+// that the policy key may take in the different Google APIs
+var allowedPolicyRefs = map[string]bool{
+	"Policy":              true,
+	"GoogleIamV1Policy":   true,
+	"ApigatewayPolicy":    true,
+	"IamPolicy":           true,
+	"GoogleIamV1__Policy": true,
+}
+
 var sanizitedCollectionIds = map[string]string{
 	// Storage doesn't use properly RESTful resource path in request.
 	"b": "buckets",
@@ -53,28 +65,37 @@ func main() {
 
 func checkResource(name string, fullPath string, resource *discovery.RestResource, doc *discovery.RestDescription, docMeta *discovery.DirectoryListItems, config iamutil.GeneratedResources) error {
 	for rName, child := range resource.Resources {
-		checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config)
+		err := checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config)
+		if err != nil {
+			return err
+		}
 	}
 
 	getM, hasGet := resource.Methods["getIamPolicy"]
 	setM, hasSet := resource.Methods["setIamPolicy"]
 
-	if !hasGet && !hasSet {
+	if !hasGet || !hasSet {
+		// Can't manage anything without both setIamPolicy and getIamPolicy
 		return nil
 	}
 
 	getK := strings.Join(getM.ParameterOrder, "/")
+	typeKey, replacementMap, err := parseTypeKey(doc.RootUrl+doc.ServicePath, &getM)
+	if err != nil {
+		return err
+	}
+
+	// if an override is available for this resource, no need to check
+	if _, ok := resourceOverrides[typeKey]; ok {
+		return nil
+	}
+
 	setK := strings.Join(setM.ParameterOrder, "/")
 
 	if getK != setK {
 		return fmt.Errorf("unexpected method formats, get parameters: %s, set parameters: %s", getK, setK)
 	}
 
-	typeKey, replacementMap, err := parseTypeKey(doc.RootUrl+doc.ServicePath, &getM)
-	if err != nil {
-		return err
-	}
-
 	var requestTmpl string
 	if tmpl, ok := correctedRequestFormats[doc.Name]; ok {
 		requestTmpl = tmpl
@@ -173,7 +194,7 @@ func parseTypeKeyFromPattern(pattern string) string {
 }
 
 func getPolicyReplacementString(sch *discovery.JsonSchema) string {
-	if sch.Id == "Policy" || sch.Ref == "Policy" {
+	if sch.Id == "Policy" || allowedPolicyRefs[sch.Ref] {
 		return "%s"
 	}
 
@@ -199,12 +220,7 @@ func addToConfig(resourceKey, service, version string, r iamutil.RestResource, c
 }
 
 func generateConfig() error {
-	docsClient, err := discovery.New(cleanhttp.DefaultClient())
-	if err != nil {
-		return err
-	}
-
-	docs, err := docsClient.Apis.List().Do()
+	docs, err := getURL[discovery.DirectoryList]("https://www.googleapis.com/discovery/v1/apis")
 	if err != nil {
 		return err
 	}
@@ -214,34 +230,26 @@ func generateConfig() error {
 
 	config := make(iamutil.GeneratedResources)
 
-	var mErr *multierror.Error
+	var mErr error
 	for _, docMeta := range docs.Items {
-		doc, docErr := docsClient.Apis.GetRest(docMeta.Name, docMeta.Version).Fields(
-			"name",
-			"resources",
-			"rootUrl",
-			"schemas",
-			"servicePath",
-			"version",
-		).Do()
+		if versions, ok := resourceSkips[docMeta.Name]; ok {
+			if _, ok := versions[docMeta.Version]; ok {
+				log.Printf("skipping %q (version %q)", docMeta.Name, docMeta.Version)
+				continue
+			}
+		}
+		doc, docErr := getURL[discovery.RestDescription](docMeta.DiscoveryRestUrl)
 		if docErr != nil || doc == nil {
-			mErr = multierror.Append(mErr,
-				errwrap.Wrapf(
-					fmt.Sprintf("[WARNING] Unable to add '%s' (version '%s'), could not find doc - {{err}}", docMeta.Name, docMeta.Version), docErr))
+			mErr = errors.Join(mErr, fmt.Errorf("unable to add %q (version %q), could not find doc - %w", docMeta.Name, docMeta.Version, docErr))
 			continue
 		}
 
 		for rName, resource := range doc.Resources {
 			if resErr := checkResource(rName, rName, &resource, doc, docMeta, config); resErr != nil {
-				mErr = multierror.Append(mErr,
-					errwrap.Wrapf(
-						fmt.Sprintf("[WARNING] Unable to add '%s' (version '%s'): {{err}}", docMeta.Name, docMeta.Version), resErr))
+				mErr = errors.Join(mErr, fmt.Errorf("unable to add %q (version %q): %w", docMeta.Name, docMeta.Version, resErr))
 			}
 		}
 	}
-	if mErr.ErrorOrNil() != nil {
-		return mErr.ErrorOrNil()
-	}
 
 	// Inject overrides that use ACLs instead of IAM policies
 	for k, v := range resourceOverrides {
@@ -252,12 +260,35 @@ func generateConfig() error {
 		return err
 	}
 
+	if mErr != nil {
+		return fmt.Errorf("errors while generating config: \n%s", mErr)
+	}
 	return nil
 }
 
-func writeConfig(config iamutil.GeneratedResources) error {
+func getURL[T any](url string) (*T, error) {
+	var t T
+	listResp, err := http.Get(url)
+	if err != nil {
+		return &t, err
+	}
+	defer listResp.Body.Close()
+	if listResp.StatusCode != http.StatusOK {
+		return &t, fmt.Errorf("unexpected status code %d from GET %s", listResp.StatusCode, url)
+	}
+	listBody, err := io.ReadAll(listResp.Body)
+	if err != nil {
+		return &t, err
+	}
+	if err := json.Unmarshal(listBody, &t); err != nil {
+		return &t, err
+	}
+
+	return &t, nil
+}
 
-	tpl, err := template.ParseFiles(fmt.Sprintf("internal/%s", templateFile))
+func writeConfig(config iamutil.GeneratedResources) error {
+	tpl, err := template.ParseFiles(filepath.Join("internal", templateFile))
 	if err != nil {
 		return err
 	}
@@ -269,8 +300,8 @@ func writeConfig(config iamutil.GeneratedResources) error {
 
 	srcBytes, err := format.Source(buf.Bytes())
 	if err != nil {
-		log.Printf("[ERROR] Outputting unformatted src:\n %s\n", string(buf.Bytes()))
-		return errwrap.Wrapf("error formatting generated code: {{err}}", err)
+		log.Printf("[ERROR] Outputting unformatted src:\n %s\n", buf.String())
+		return fmt.Errorf("error formatting generated code: %w", err)
 	}
 
 	dst, err := os.Create(outputFile)

plugin/iamutil/internal/resource_config_template

@@ -1,4 +1,7 @@
 {{define "main"}}
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
 // THIS FILE IS AUTOGENERATED USING go generate. DO NOT EDIT.
 package iamutil
 

plugin/iamutil/internal/resource_overrides.go

@@ -34,4 +34,61 @@ var resourceOverrides = map[string]map[string]map[string]iamutil.RestResource{
 			},
 		},
 	},
+	"projects/datasets/tables": {
+		"bigquery": {
+			"v2": iamutil.RestResource{
+				Name:                      "tables",
+				TypeKey:                   "projects/datasets/tables",
+				Service:                   "bigquery",
+				IsPreferredVersion:        true,
+				Parameters:                []string{"resource"},
+				CollectionReplacementKeys: map[string]string{},
+				GetMethod: iamutil.RestMethod{
+					HttpMethod: "GET",
+					BaseURL:    "https://bigquery.googleapis.com",
+					Path:       "bigquery/v2/{+resource}:getIamPolicy",
+				},
+				SetMethod: iamutil.RestMethod{
+					HttpMethod: "PATCH",
+					BaseURL:    "https://bigquery.googleapis.com",
+					// NOTE: the bigquery portion of the path needs to be in
+					// the version since googleapis removes it from the
+					// BaseURL when resolving
+					Path:          "bigquery/v2/{+resource}:setIamPolicy",
+					RequestFormat: `{"policy": %s}`,
+				},
+			},
+		},
+	},
+	"projects/datasets/routines": {
+		"bigquery": {
+			"v2": iamutil.RestResource{
+				Name:                      "routines",
+				TypeKey:                   "projects/datasets/routines",
+				Service:                   "bigquery",
+				IsPreferredVersion:        true,
+				Parameters:                []string{"resource"},
+				CollectionReplacementKeys: map[string]string{},
+				GetMethod: iamutil.RestMethod{
+					HttpMethod: "GET",
+					BaseURL:    "https://bigquery.googleapis.com",
+					Path:       "bigquery/v2/{+resource}:getIamPolicy",
+				},
+				SetMethod: iamutil.RestMethod{
+					HttpMethod: "PATCH",
+					BaseURL:    "https://bigquery.googleapis.com",
+					// NOTE: the bigquery portion of the path needs to be in
+					// the version since googleapis removes it from the
+					// BaseURL when resolving
+					Path:          "bigquery/v2/{+resource}:setIamPolicy",
+					RequestFormat: `{"policy": %s}`,
+				},
+			},
+		},
+	},
+}
+
+var resourceSkips = map[string]map[string]struct{}{
+	"poly":            {"v1": {}},      // Advertised as available at https://poly.googleapis.com/$discovery/rest?alt=json&prettyPrint=false&version=v1, but returns a 502
+	"realtimebidding": {"v1alpha": {}}, // Advertised as available at https://realtimebidding.googleapis.com/$discovery/rest?alt=json&prettyPrint=false&version=v1alpha, but returns a 404
 }

plugin/iamutil/resource_parser_test.go

@@ -103,7 +103,7 @@ func constructSelfLink(relName string, cfg RestResource) (string, error) {
 	if startI < 0 {
 		return "", fmt.Errorf("unexpected request URL in resource does not have proper parameter to be replaced: %s", reqUrl)
 	}
-	return reqUrl[:startI] + relName, nil
+	return reqUrl[:endI] + relName, nil
 }
 
 func TestEnabledIamResources_SelfLink(t *testing.T) {