Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic if bindings aren't provided #55

Closed
kalafut opened this issue Nov 19, 2019 · 1 comment · Fixed by #56
Closed

Panic if bindings aren't provided #55

kalafut opened this issue Nov 19, 2019 · 1 comment · Fixed by #56
Labels
bug Something isn't working

Comments

@kalafut
Copy link
Contributor

kalafut commented Nov 19, 2019

Missing type assertion check at: https://github.com/hashicorp/vault-plugin-secrets-gcp/blob/master/plugin/path_role_set.go#L350

2019-11-18T16:09:33.987-0800 [DEBUG] secrets.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp_a970d460.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp: panic: interface conversion: interface {} is nil, not string
2019-11-18T16:09:33.987-0800 [DEBUG] secrets.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp_a970d460.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp:
2019-11-18T16:09:33.987-0800 [DEBUG] secrets.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp_a970d460.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp: goroutine 125 [running]:
2019-11-18T16:09:33.987-0800 [DEBUG] secrets.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp_a970d460.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp: github.com/hashicorp/vault-plugin-secrets-gcp/plugin.(*backend).pathRoleSetCreateUpdate(0xc0002b8510, 0x187fde0, 0xc0002b8ae0, 0xc0002f0640, 0xc00025c120, 0x8000101, 0x0, 0xffffffffffffffff)
2019-11-18T16:09:33.987-0800 [DEBUG] secrets.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp_a970d460.vault-plugin-secrets-gcp.vault-plugin-secrets-gcp: 	/Users/kalafut/go/src/github.com/hashicorp/vault-plugin-secrets-gcp/plugin/path_role_set.go:350 +0x1d5d
@kalafut kalafut added the bug Something isn't working label Nov 19, 2019
@sethvargo sethvargo mentioned this issue Nov 19, 2019
Merged
@sethvargo
Copy link
Contributor

#56

kalafut pushed a commit that referenced this issue Nov 19, 2019
@sethvargo @kalafut
Fix panic on assertion (#56)
77f4de2 
Fixes #55
kalafut pushed a commit that referenced this issue Dec 16, 2019
@sethvargo
Fix panic on assertion (#56)
d94ed7c 
Fixes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic on assertion
2 participants
@kalafut @sethvargo