allow lazy decrypted vault attributes to be referenced after a destroy #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisarcand
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
I think this workaround is very reasonable as a default, and defines behavior that was never guaranteed before anyway.
If there's some reason that it's undesirable to load lazy attributes on destroys, the inverse of your second option (forcing a destroy without loading the attributes) can be added later.
joekarl
approved these changes
Sep 29, 2020
After destroying a record, ActiveRecord marks the in-memory object as frozen and unable to be altered. This is fine, unless lazy decrypt is enabled and you need to access an encrypted attribute after the destroy happens - for instance, as part of a dependent: :destroy chain. In that case, vault-rails will attempt to set the plaintext attribute _after_ the destroy, raising a "Can't modify frozen hash" error. This commit ensures that encrypted attributes are always decrypted prior to a destroy.
radditude
force-pushed
the
radditude/access-attribute-after-destroy
branch
from
c77c493 to
b451a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After destroying a record, ActiveRecord marks the in-memory object as frozen and unable to be altered. This was fine in older versions of Rails prior to the attributes API, and it's mostly fine now. However, if lazy decrypt is enabled and you need to access an encrypted attribute after the destroy happens -- for instance, as part of a
dependent: :destroychain -- vault-rails attempts to set the plaintext attribute on the frozen object, raising a "Can't modify frozen hash" error.As a workaround, this PR ensures that attributes are decrypted before a destroy so the plain text values can be accessed by after-destroy hooks if needed.
Currently, I've set this as universal behavior, since being able to access encrypted attributes after a destroy was the default prior to #67. However, another possibility would be only enabling this behavior for specific attributes, via something along these lines: