Skip to content

Commit

Permalink
Handle client count timezone (#15167)
Browse files Browse the repository at this point in the history
* Handle client count timezone

- Backend convert the timezone to UTC, to mitigate it's impact sending
  start and end date other than 1. Chose 10 and 20 randomly.

* Added changelog
  • Loading branch information
arnav28 authored May 20, 2022
1 parent a38678d commit 2ceb100
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelog/15167.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixed client count timezone for start and end months
```
6 changes: 4 additions & 2 deletions ui/app/adapters/clients/activity.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,21 @@ import Application from '../application';
import { formatRFC3339 } from 'date-fns';

export default Application.extend({
// Since backend converts the timezone to UTC, sending the first (1) as start or end date can cause the month to change.
// To mitigate this impact of timezone conversion, hard coding the dates to avoid month change.
formatTimeParams(query) {
let { start_time, end_time } = query;
// check if it's an array, if it is, it's coming from an action like selecting a new startTime or new EndTime
if (Array.isArray(start_time)) {
let startYear = Number(start_time[0]);
let startMonth = Number(start_time[1]);
start_time = formatRFC3339(new Date(startYear, startMonth));
start_time = formatRFC3339(new Date(startYear, startMonth, 10));
}
if (end_time) {
if (Array.isArray(end_time)) {
let endYear = Number(end_time[0]);
let endMonth = Number(end_time[1]);
end_time = formatRFC3339(new Date(endYear, endMonth));
end_time = formatRFC3339(new Date(endYear, endMonth, 20));
}

return { start_time, end_time };
Expand Down

0 comments on commit 2ceb100

Please sign in to comment.