Fix swallowed errors in TestRollbackManager_Join() (#3327)

hashicorp · Nov 6, 2017 · 5fea9df · 5fea9df
1 parent b490018
commit 5fea9df
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/vault/rollback_test.go b/vault/rollback_test.go
@@ -81,28 +81,34 @@ func TestRollbackManager_Join(t *testing.T) {
 	wg := &sync.WaitGroup{}
 	wg.Add(3)
 
+	errCh := make(chan error, 3)
 	go func() {
 		defer wg.Done()
 		err := m.Rollback("foo")
 		if err != nil {
-			t.Fatalf("err: %v", err)
+			errCh <- err
 		}
 	}()
 
 	go func() {
 		defer wg.Done()
 		err := m.Rollback("foo")
 		if err != nil {
-			t.Fatalf("err: %v", err)
+			errCh <- err
 		}
 	}()
 
 	go func() {
 		defer wg.Done()
 		err := m.Rollback("foo")
 		if err != nil {
-			t.Fatalf("err: %v", err)
+			errCh <- err
 		}
 	}()
 	wg.Wait()
+	close(errCh)
+	err := <-errCh
+	if err != nil {
+		t.Fatalf("Error on rollback:%v", err)
+	}
 }