Current Month Activity Estimate, Probabilistic Tests, And Bugfixes (#…

…16447)

* bugfixes and probabilistic hll tests

* changelog

* changelog fix

* remove activity log test and keep in ent

* update cl

changelog/16447.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+activity: Add timestamp to current month calculation and remove deduplication for current month
+```

vault/activity_log_util_common.go

@@ -76,7 +76,7 @@ func (a *ActivityLog) computeCurrentMonthForBillingPeriodInternal(ctx context.Co
 	// client data is stored. The path at which the hyperloglog for a month is stored containes this timestamp.
 	hllMonthlyTimestamp := timeutil.StartOfMonth(startTime)
 	billingPeriodHLL := hyperloglog.New()
-	for hllMonthlyTimestamp.Before(timeutil.StartOfMonth(endTime)) || hllMonthlyTimestamp.Equal(timeutil.StartOfMonth(endTime)) {
+	for hllMonthlyTimestamp.Before(timeutil.StartOfMonth(endTime)) {
 		monthSketch, err := hllGetFunc(ctx, hllMonthlyTimestamp)
 		// If there's an error with the hyperloglog fetch, we should still deduplicate on
 		// the hlls that we have so we will warn that we couldn't find a hll for the month
@@ -146,6 +146,7 @@ func (a *ActivityLog) computeCurrentMonthForBillingPeriodInternal(ctx context.Co
 	currentMonthNewNonEntities := billingPeriodHLLWithCurrentMonthNonEntityClients.Estimate() - billingPeriodHLL.Estimate()
 
 	return &activity.MonthRecord{
+		Timestamp:  timeutil.StartOfMonth(endTime).UTC().Unix(),
 		NewClients: &activity.NewClientRecord{Counts: &activity.CountsRecord{EntityClients: int(currentMonthNewEntities), NonEntityClients: int(currentMonthNewNonEntities)}},
 		Counts:     &activity.CountsRecord{EntityClients: totalEntities, NonEntityClients: totalNonEntities},
 	}, nil