UI - kv save error (#6022)

* don't prevent model save when the model is in the error state on secrets creation * add test
hashicorp · Jan 10, 2019 · 8da2e1e · 8da2e1e
1 parent fe5d47e
commit 8da2e1e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/ui/app/components/secret-edit.js b/ui/app/components/secret-edit.js
@@ -134,14 +134,7 @@ export default Component.extend(FocusOnInsertMixin, WithNavToNearestAncestor, {
 
   requestInFlight: or('model.isLoading', 'model.isReloading', 'model.isSaving'),
 
-  buttonDisabled: or(
-    'requestInFlight',
-    'model.isFolder',
-    'model.isError',
-    'model.flagsIsInvalid',
-    'hasLintError',
-    'error'
-  ),
+  buttonDisabled: or('requestInFlight', 'model.isFolder', 'model.flagsIsInvalid', 'hasLintError', 'error'),
 
   modelForData: computed('isV2', 'model', function() {
     return this.isV2 ? this.model.belongsTo('selectedVersion').value() : this.model;

diff --git a/ui/tests/integration/components/secret-edit-test.js b/ui/tests/integration/components/secret-edit-test.js
@@ -69,6 +69,20 @@ module('Integration | Component | secret edit', function(hooks) {
     assert.dom('[data-test-error]').includesText('Vault expects data to be formatted as an JSON object');
   });
 
+  test('it allows saving when the model isError', async function(assert) {
+    this.set('mode', 'create');
+    this.set('model', {
+      isError: true,
+      secretData: {
+        int: '2',
+        null: 'null',
+        float: '1.234',
+      },
+    });
+    await render(hbs`<SecretEdit @mode={{mode}} @model={{model}} />`);
+    assert.dom('[data-test-secret-save]').isNotDisabled();
+  });
+
   test('it shows an error when editing and the data is not an object', async function(assert) {
     this.set('mode', 'edit');
     capabilities = {