Skip to content

Commit

Permalink
Updated comments on how this test catches parsePEM bug.
Browse files Browse the repository at this point in the history
  • Loading branch information
kitography committed Feb 3, 2025
1 parent 0543204 commit d490bf4
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions builtin/logical/pki/cert_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1062,13 +1062,17 @@ func testParseCsrToFields(t *testing.T, issueTime time.Time, tt *parseCertificat
// entire CA chain.
//
// This test constructs a root CA that
// - allows: .example.com
// - allows: .example.com and myint.com
// - excludes: bad.example.com
//
// and an intermediate that
// - forbids alsobad.example.com
//
// It verifies that the intermediate
// By importing the intermediate chain in the "wrong" order, it validates parsePEM
// is using the updated verification logic, not the historical strict one which
// prevented multi-chains.
//
// It then checks verification by issuing from the intermediate certificate:
// - can issue certs like good.example.com
// - rejects names like notanexample.com since they are not in the namespace of names permitted by the root CA
// - rejects bad.example.com, since the root CA excludes it
Expand Down

0 comments on commit d490bf4

Please sign in to comment.