-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKI Engine: Error parsing metadata when creating ed25519 or ec root cert #13680
Comments
Having the same issue with a signed intermediate certificate. Checking with openssl provides sane output from the pem file. Vault cannot successfully parse the certificate metadata. Intermediate using ec with 384 bits. |
Did a bit more testing on this....as it's a development system it's easy to mess about. Pulled in the offline root CA to Vaultas part of creating a new pki endpoint. |
Our web UI uses the As mentioned by @pcuttriss, perhaps fetching the cert (which can be done unauthenticated) and parsed by
I agree the
Perhaps a /cc @hellobontempo |
This replaces the implementation of parse-pki-cert to use PKI.js rather than node-forge for two reasons: - PKI.js uses Web Crypto rather than maintaining a built-in implementation of several algorithms. - node-forge presently lacks support for ECDSA and Ed25519 certificates. Related: #13680 Signed-off-by: Alexander Scheel <[email protected]>
* Switch parse-pki-cert from node-forge to PKI.js This replaces the implementation of parse-pki-cert to use PKI.js rather than node-forge for two reasons: - PKI.js uses Web Crypto rather than maintaining a built-in implementation of several algorithms. - node-forge presently lacks support for ECDSA and Ed25519 certificates. Related: #13680 Signed-off-by: Alexander Scheel <[email protected]> * Add dependency on PKI.js $ yarn add -D asn1js pvutils pkijs Signed-off-by: Alexander Scheel <[email protected]> * Remove dependency on node-forge $ yarn remove node-forge Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]>
* Switch parse-pki-cert from node-forge to PKI.js This replaces the implementation of parse-pki-cert to use PKI.js rather than node-forge for two reasons: - PKI.js uses Web Crypto rather than maintaining a built-in implementation of several algorithms. - node-forge presently lacks support for ECDSA and Ed25519 certificates. Related: #13680 Signed-off-by: Alexander Scheel <[email protected]> * Add dependency on PKI.js $ yarn add -D asn1js pvutils pkijs Signed-off-by: Alexander Scheel <[email protected]> * Remove dependency on node-forge $ yarn remove node-forge Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]>
Describe the bug
When generating a new root certificate of the key_type ed25519 or ec I get an error regarding that the metadata couldn't be parsed and therefore I can't see the common_name or expiration dates. This problem does not happen when I use rsa as key_type. In the Vault UI, I get following Info Message:
The generated certificate is valid for the set amount, but not being able to see the expiration date via API or CLI makes it hard to monitor. Are there any limitations I am not aware of?
To Reproduce
Steps to reproduce the behavior:
vault secrets enable pki
vault secrets tune --max-lease-ttl=87600h pki
vault write -field=certificate pki/root/generate/internal common_name="root" ttl=87600h key_type=ed25519
I also tried this with lower TTls or with and without common_name resulting in the same error.
Expected behavior
Root Cert supports ed25519 with all metadata so it can be queried by API or CLI!
Environment:
Vault server configuration file(s):
Can be provided, if needed. The cluster is using raft as storage backend.
The text was updated successfully, but these errors were encountered: