Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent doesn't proxy GET parameters on health check #6738

Closed
sgmiller opened this issue May 15, 2019 · 0 comments · Fixed by #6772
Closed

Agent doesn't proxy GET parameters on health check #6738

sgmiller opened this issue May 15, 2019 · 0 comments · Fixed by #6772
Assignees
Milestone

Comments

@sgmiller
Copy link
Collaborator

Describe the bug
When issuing a request to /v1/sys/health with query parameters (such as standbyok), those parameters are not proxied to Vault.

This means we can't set up a health check in Kubernetes as it expects 200.

To Reproduce
Steps to reproduce the behavior:

  1. curl http://localhost:8200/v1/sys/health?standbyok=true
  2. Note the 429 response if the agent proxies to a standby node.

Expected behavior
Query parameters should be supported by the agent.

Environment:
All versions 1.1.2.
Linux x86-64
Vault server configuration file(s):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants