agent/caching: support proxying request query parameters #6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
commented
May 21, 2019
| // Make the request to Vault and get the response | ||
| ap.logger.Info("forwarding request", "path", req.Request.URL.Path, "method", req.Request.Method) |
There was a problem hiding this comment.
I swapped the log message ordering on "method" and "path" since it looks nicer IMO (similar to the browser's inspection console log messages), but can revert it back if we don't want this change.
jefferai
previously approved these changes
May 22, 2019
briankassouf
previously approved these changes
May 22, 2019
briankassouf
pushed a commit
that referenced
this pull request
Jun 4, 2019
* agent/caching: support proxying request query parameters * update comment * rejig other agent log messages to output method followed by path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6738