Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport leader status telemetry [VAULT-672] #10147

Merged
merged 12 commits into from
Oct 15, 2020
Merged

Conversation

HridoyRoy
Copy link
Contributor

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 14, 2020

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • HridoyRoy
  • Hridoy Roy

Hridoy Roy seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@HridoyRoy HridoyRoy requested a review from mgritter October 14, 2020 14:04
@HridoyRoy
Copy link
Contributor Author

PR Update: CI tests were not running because of vendor issues. Needed to run go mod vendor and clean go.mod and go.sum in order for the tests to pass (go.mod somehow pulled in a conflicting metricsutil package). Go mod vendor made this a large change. Glancing through the vendor changes, they all seem pretty mild and CI does seem to pass, but I'm re-requesting reviews just to be on the safe side.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants