agent/auth/cert: fix reauthentication when certs specified in config #10348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vault agent was failing to reauthenticate with cert auth method, when the agent auto_auth method is configured with a client certificate. It had been broken since hashicorp#9819, Vault v1.5.1. Adding E2E test to avoid the same bug in future. Signed-off-by: Sorah Fukumori <[email protected]>
|
|
|
test failures seem unrelated to my change |
|
@calvn could you take a look at this please? |
|
This was fixed in #11576; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault agent is failing to reauthenticate with cert auth method, when the agent auto_auth method is configured with a client certificate.
It has been broken since #9819, Vault v1.5.1.
Adding E2E test to avoid the same bug in future.