Only set the namespace if the env var isn't present (#1519) #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Dec 14, 2020
This has been moved to its own file in the ent repo
ncabatoff
reviewed
Dec 14, 2020
changelog/10556.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| agent: Only set the namespace if the env var isn't present | |||
There was a problem hiding this comment.
Do we want to name the env var here?
ncabatoff
approved these changes
Dec 14, 2020
raskchanky
added a commit
that referenced
this pull request
Dec 14, 2020
raskchanky
added a commit
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly opened https://github.com/hashicorp/vault-enterprise/pull/1519 against the ent repo, when it should've been against this one. This back ports those changes.