Bug Fix: allow click of label and box for box-radio component #10586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
approved these changes
Dec 16, 2020
| @@ -16,11 +16,13 @@ | |||
| * @param {string} [tooltipMessage=default] - The message that shows in the tooltip if the radio option is disabled | |||
| */ | |||
|
|
|||
| import Component from '@ember/component'; | |||
| import Component from '@glimmer/component'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're now in Glimmer land and this is not a crucial fix that needs to be backported, I went ahead and transformed the
box-radiocomponent to a glimmer component.The main fix was removing the extra label element and adjusting the style.
With fix (before you could not click on the round radio button to select)