MySQL - Add username customization #10834
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/9awh7gpvn |
| @@ -483,35 +718,6 @@ func TestMySQL_UpdateUser(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMySQL_Initialize_ReservedChars(t *testing.T) { | |||
There was a problem hiding this comment.
This test was added for coverage against a bug that we ended up fixing and is not specific to templating, but rather a check against this codeblock. We might want to keep it around.
There was a problem hiding this comment.
This is being checked in the TestMySQL_Initialize table tests as the password being used is the same as in this tests. I'll see about making this check more explicit though. I'd like to keep it in the table tests, but TBD on whether that's reasonable.
There was a problem hiding this comment.
Looks like you've addressed this on 716ddc4, thanks!
Adds the ability to customize username generation for dynamic users in MySQL.
Uses the new field
username_templatewith the go template language.