Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/fix backend db connection #11127

Merged
merged 6 commits into from
Mar 17, 2021
Merged

UI/fix backend db connection #11127

merged 6 commits into from
Mar 17, 2021

Conversation

chelshaw
Copy link
Contributor

Fixes bug where only database secret engine connection actions backend was hardcoded. This change allows any named database to accomplish connection actions such as edit and rotate.

@chelshaw chelshaw added ui backport bug Used to indicate a potential bug labels Mar 17, 2021
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2021 16:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2021 16:28 Inactive
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2021 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2021 20:34 Inactive
@chelshaw chelshaw merged commit 3e3db9f into master Mar 17, 2021
@chelshaw chelshaw deleted the ui/fix-backend-db-connection branch March 17, 2021 20:48
chelshaw added a commit that referenced this pull request Mar 17, 2021
* Update adapter so any named database backend will work

* Add test for deleting database connection
chelshaw added a commit that referenced this pull request Mar 18, 2021
* Update adapter so any named database backend will work

* Add test for deleting database connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants