Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-11067 updated region eu-west-2 with credential and region #11363

Closed
wants to merge 2 commits into from

Conversation

prassawant
Copy link

what I found out that in default.go the sts services is not defined for eu-west-2, so added the code

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


U-MASTEK\PrashantS seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – vault April 15, 2021 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 15, 2021 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 15, 2021 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 15, 2021 15:31 Inactive
@vishalnayak
Copy link
Contributor

This feels like it should go in as a PR on the upstream repository to update this file. https://github.com/aws/aws-sdk-go/blob/main/aws/endpoints/defaults.go

Then, the dependency to that library in Vault can be updated to bring in that change.

We don't manually make any changes to the vendored files. Sorry.

@vishalnayak vishalnayak closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants