pki: fix tidy removal on revoked entries #11367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
approved these changes
Apr 19, 2021
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
* pki: fix tidy removal on revoked entries * add CL entry
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
* pki: fix tidy removal on revoked entries * add CL entry
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
* pki: fix tidy removal on revoked entries * add CL entry
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
calvn
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by #9609 in which entries under
revoked/are removed from storage if a tidy operation is performed withtidy_revoked_certsset totrueeven if the certificate'sNotAftervalue is has not been past the current time yet. This can be problematic since it can result in the removal of said certs from the CRL, which uses entries underrevoked/to construct the revoked certs list.