Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1.5.x go 1.14.15 #11397

Merged
merged 5 commits into from
Apr 19, 2021
Merged

Update 1.5.x go 1.14.15 #11397

merged 5 commits into from
Apr 19, 2021

Conversation

vishalnayak
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault – ./website

🔍 Inspect: https://vercel.com/hashicorp/vault/5eySTgZ6nMBC1LGfJ2V7KAY14ff6
✅ Preview: Failed

[Deployment for fafe38f failed]

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/6ddsHbRkodyKjAmoqSzbnYCzzUFq
✅ Preview: Canceled

[Deployment for fafe38f canceled]

@vercel vercel bot temporarily deployed to Preview – vault-storybook April 19, 2021 15:28 Inactive
@vishalnayak vishalnayak changed the base branch from master to release/1.5.x April 19, 2021 15:29
@vishalnayak vishalnayak added this to the 1.5.8 milestone Apr 19, 2021
vishalnayak
vishalnayak commented Apr 19, 2021
View reviewed changes
scripts/cross/Dockerfile Outdated
@@ -21,7 +21,7 @@ RUN apt-get update -y && apt-get install -y -q nodejs yarn
RUN rm -rf /var/lib/apt/lists/*


ENV GOVERSION 1.13.8
ENV GOVERSION 1.14.15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a documented change and also felt a bit off because its modified from 1.13.8 and not 1.14.7. Is this correct? Unlike the newer release branches, there isn't a Dockerfile in release/1.4.x/scripts/docker, which is why I went this route, but I am unsure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reverting this, as previous PRs on this branch to update Go didn't modify this file.

@vercel vercel bot temporarily deployed to Preview – vault-storybook April 19, 2021 16:44 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 19, 2021 16:53 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 19, 2021 17:38 Inactive
@kalafut kalafut merged commit be6b0e6 into release/1.5.x Apr 19, 2021
@kalafut kalafut deleted the update-1.5.x-go-1.14.15 branch April 19, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@kalafut kalafut Awaiting requested review from kalafut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalnayak @briankassouf @kalafut