When running under systemd, send notifications about server startup, shutdown, and config reload #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shutdown, and config reload
swayne275
requested changes
May 3, 2021
command/server.go
Outdated
| if sent { | ||
| c.logger.Debug("sent systemd notification", "notification", status) | ||
| } else { | ||
| c.logger.Debug("would have sent systemd notification (systemd not present)", "notification", status) |
There was a problem hiding this comment.
these are likely very infrequent, but why do we want this log?
There was a problem hiding this comment.
also i think this can be inaccurate if err != nil - I looked at SdNotify and it'll return false with a non-nil error so this log might be confusing?
There was a problem hiding this comment.
The logging was partially to assist implementation, but could also help people debugging since it requires correct configuration in systemd to work as well. You're right that the if sent/else block should only happen if err is nil.
swayne275
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a noop on systems without systemd, and when not spawned by systemd. Note that "Type=notify" must be specified in the systemd service definition in order for systemd to spawn a notification socket and set the corresponding environment variable.