Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exponential backoff to TCP listeners to avoid fast loops in error scenarios #11588

Merged
merged 3 commits into from
May 12, 2021

Conversation

sgmiller
Copy link
Collaborator

In cases like too many open files, the TCP listener Accept loop retries as
fast as it can, leading to excessive resource consumption. This adds a
short (<1s) exponential backoff to those cases.

@vercel vercel bot temporarily deployed to Preview – vault May 11, 2021 21:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook May 11, 2021 21:36 Inactive
@sgmiller
Copy link
Collaborator Author

Borrows the code from other Hashicorp projects and follows the ENG-018 RFC.

@sgmiller sgmiller requested a review from swayne275 May 11, 2021 21:37
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sgmiller sgmiller merged commit f12f24b into master May 12, 2021
@sgmiller sgmiller deleted the listener-backoff branch May 12, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants