Implement ember-cp-validations on KV secret engine #11785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
Jun 11, 2021
| @message="Your policies prevent you from reading the current secret data. Saving using this form will overwrite the existing values." | ||
| @class="is-marginless" | ||
| data-test-v1-write-without-read | ||
| {{#if (and (or @model.isNew @canEditV2Secret) @isV2 (not @model.failedServerRead))}} |
There was a problem hiding this comment.
fixing spacing here, hence the big diff.
hashishaw
suggested changes
Jun 11, 2021
| return; | ||
| } | ||
| const maxVersions = secret.get('maxVersions'); | ||
| if (MAXIMUM_VERSIONS < maxVersions) { |
There was a problem hiding this comment.
Note to future onlookers: this check was moved to secret-v2 model
| * @param attr=null {Object} - This is usually derived from ember model `attributes` lookup, and all members of `attr.options` are optional. | ||
| * @param model=null {DS.Model} - The Ember Data model that `attr` is defined on | ||
| * @param [disabled=false] {Boolean} - whether the field is disabled | ||
| * @param [showHelpText=true] {Boolean} - whether to show the tooltip with help text from OpenAPI | ||
| * @param [subText] {String} - Text to be displayed below the label | ||
| * @param [validationMessage] {String} - AlertInline error message to be displayed if cp-validation error. |
| @@ -56,6 +64,22 @@ module('Acceptance | secrets/secret/create', function(hooks) { | |||
| assert.ok(showPage.editIsPresent, 'shows the edit button'); | |||
| }); | |||
|
|
|||
| test('it disables save when validation errors occur', async function(assert) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One PR of many to come where we'll be adding form validations to various forms in the application. This first PR tackles the KV secret engine.
In an earlier demo, I used the ember-changeset-validations library. In this, I'm using the ember-cp-validations library and I much prefer the latter. It does not modify the whole model object but instead adds to it using a mixin. It's much easier to use, and more importantly, it should be usable in new glimmer components.
Notes:
max_versionsis not saving on create. This will be addressed in another ticket.Path
Create and Edit Secret
