Handle form validation for open api form #11963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnav28
commented
Jun 29, 2021
arnav28
commented
- Added required validator for all the default fields
- Added required validator for all the default fields
Monkeychip
reviewed
Jul 1, 2021
ui/app/components/generated-item.js
Outdated
| ? set(this.validationMessages, name, '') | ||
| : set(this.validationMessages, name, this.model.validations.attrs[name].message); | ||
|
|
||
| // Set form button state |
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
reviewed
Jul 1, 2021
| @@ -106,6 +106,7 @@ | |||
|
|
|||
| .message-inline { | |||
| display: flex; | |||
| align-items: center; | |||
There was a problem hiding this comment.
is this going to be true for all message-inline? worth checking that this doesn't have consequences elsewhere.
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
reviewed
Jul 1, 2021
Monkeychip
requested changes
Jul 1, 2021
There was a problem hiding this comment.
This looks really good. A couple of comments, and the following requests:
- Can you add a gif to the PR that shows the validations and how they work?
- Can you add test coverage for this particular validation? You can look at my earlier PR that does this. See file here.
- We are now required to add a changelog for every pr; it can just be something that expands off the previous validations changelogs, specifying the actual validation target here.
Screen.Recording.2021-07-06.at.11.28.45.AM.mov |
- Handle read only inputs during edit mode
hashishaw
reviewed
Jul 12, 2021
hashishaw
reviewed
Jul 12, 2021
Monkeychip
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.