Redshift - Add username customization #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestRan existing acceptance tests and manually tested that username customization works as expected === RUN TestRedshift_Initialize
--- PASS: TestRedshift_Initialize (0.48s)
=== RUN TestRedshift_NewUser
--- PASS: TestRedshift_NewUser (2.85s)
=== RUN TestRedshift_NewUser_NoCreationStatement_ShouldError
--- PASS: TestRedshift_NewUser_NoCreationStatement_ShouldError (0.42s)
=== RUN TestRedshift_UpdateUser_Expiration
--- PASS: TestRedshift_UpdateUser_Expiration (11.14s)
=== RUN TestRedshift_UpdateUser_Password
--- PASS: TestRedshift_UpdateUser_Password (3.49s)
=== RUN TestRedshift_DeleteUser
--- PASS: TestRedshift_DeleteUser (6.53s)
=== RUN TestRedshift_DefaultUsernameTemplate
--- PASS: TestRedshift_DefaultUsernameTemplate (2.78s)
=== RUN TestRedshift_CustomUsernameTemplate
--- PASS: TestRedshift_CustomUsernameTemplate (2.70s)
PASS
ok github.com/hashicorp/vault/plugins/database/redshift 30.531s
|
MilenaHC
requested review from
jasonodonnell,
fairclothjm,
tomhjp and
austingebauer
fairclothjm
approved these changes
Jul 8, 2021
austingebauer
approved these changes
Jul 8, 2021
MilenaHC
added a commit
that referenced
this pull request
Jul 8, 2021
* username customization for redshift * adding changelog and updating api-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to customize username generation for dynamic users in Redshift.
Uses the new field
username_templatewith the go template language.