Client count updates #12554
Client count updates #12554
Conversation
arnav28
commented
Sep 15, 2021
arnav28
commented
- Added Current month tab which leverages partial monthly activity api
- Refactored Vault usage to Monthly history
- New client count history component based on StatText and BarChart component
- Restrict bar chart to showcase only top 10 namespaces
- Removed config route, as config and history component will be rendered based on query param
- Updated all metrics reference to clients
- Removed old tests and added integration test for current month
- Added Current month tab which leverages partial monthly activity api - Refactored Vault usage to Monthly history - New client count history component based on StatText and BarChart component - Restrict bar chart to showcase only top 10 namespaces - Removed config route, as config and history component will be rendered based on query param - Updated all metrics reference to clients - Removed old tests and added integration test for current month
- Added changelog
| @@ -15,9 +15,8 @@ Router.map(function() { | |||
| this.route('logout'); | |||
| this.mount('open-api-explorer', { path: '/api-explorer' }); | |||
| this.route('license'); | |||
| this.route('metrics', function() { | |||
| this.route('clients', function() { | |||
There was a problem hiding this comment.
does changing the route names affect the picker at all on the Status menu? E.g. can you still navigate to the page the same way as before?
There was a problem hiding this comment.
I updated all the references which were pointing to metrics route, so it will work fine.
| assert.dom('[data-test-tracking-disabled] .message-title').hasText('Tracking is disabled'); | ||
| }); | ||
|
|
||
| test('it shows data when available from query', async function(assert) { |
There was a problem hiding this comment.
These two test files look exactly the same, are there any differences or should they be testing the exact same thing?
There was a problem hiding this comment.
Some tests are different, such as making sure date component is not shown in current tab and also the input data is slightly different (compare last test in both files).
Yes, namespace search and couple of permissions messaging is coming in separate review :) |
