UI/Add Elasticsearch DB #12672
Merged
UI/Add Elasticsearch DB #12672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
changed the title
hellobontempo
commented
Oct 6, 2021
hellobontempo
commented
Oct 6, 2021
| tls_server_name: attr('string', { | ||
| label: 'TLS server name', | ||
| subText: 'If set, this name is used to set the SNI host when connecting via 1TLS.', | ||
| }), | ||
| root_rotation_statements: attr({ | ||
| subText: `The database statements to be executed to rotate the root user's credentials. If nothing is entered, Vault will use a reasonable default.`, | ||
| editType: 'stringArray', | ||
| defaultShown: 'Default', | ||
| }), | ||
|
|
There was a problem hiding this comment.
Databases unsupported by the UI will trigger EmptyState components in templates
hellobontempo
commented
Oct 6, 2021
| @@ -106,9 +103,9 @@ export default Model.extend({ | |||
| 'username', | |||
| 'rotation_period', | |||
| 'creation_statements', | |||
| 'creation_statement', // only for MongoDB (styling difference) | |||
There was a problem hiding this comment.
No longer just for MongoDB, Elasticsearch needed as well :)
hellobontempo
commented
Oct 6, 2021
| subText: | ||
| 'The connection string used to connect to the database. This allows for simple templating of username and password of the root user.', | ||
| label: 'URL', | ||
| subText: `The URL for Elasticsearch's API ("https://localhost:9200").`, |
There was a problem hiding this comment.
Connection works if http://127.0.0.1:9200 or https://localhost:9200
hellobontempo
commented
Oct 7, 2021
hellobontempo
commented
Oct 7, 2021
| @@ -10,7 +10,10 @@ export default create({ | |||
| dbPlugin: selectable('[data-test-input="plugin_name"]'), | |||
| name: fillable('[data-test-input="name"]'), | |||
| toggleVerify: clickable('[data-test-input="verify_connection"]'), | |||
| url: fillable('[data-test-input="connection_url"'), | |||
| connectionUrl: fillable('[data-test-input="connection_url"]'), | |||
There was a problem hiding this comment.
Changed selector to match attribute name now that we have both connection_url and url inputs
Monkeychip
reviewed
Oct 7, 2021
Monkeychip
reviewed
Oct 7, 2021
Monkeychip
reviewed
Oct 7, 2021
| {{/if}} | ||
| </ToolbarActions> | ||
| </Toolbar> | ||
| {{#if @model.isAvailablePlugin}} |
Monkeychip
reviewed
Oct 7, 2021
Monkeychip
approved these changes
Oct 7, 2021
Aha! Found the error - thanks for your comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Elasticsearch DB support to UI. Also now UI shows empty state when a database is connected via CLI but unsupported by the UI