Fix auth/aws so that config/rotate-root saves new key pair to vault #12715
Conversation
|
|
|
@ludewigh Can you please sign the CLA? (Note that the email in the commits needs to match an email on your github account) |
|
@kalafut I was hoping since my Org already had a signed CLA we would be fine, but since I need to sign as well it will most likely take another day or so to get approval. I've started our internal process and will sign as soon as I have been approved. |
|
@ludewigh if your organization has signed a CLA, and your GitHub account is associated with that organization and it's publicly viewable that you're associated, the CLA bot should do the right thing. Please let us know if there's any hiccups. Thanks! |
|
@hsimon-hashicorp I think the publicly viewable part was the issue, I've updated it from private to public so hopefully when it runs next that fixes it. |
|
@hsimon-hashicorp @kalafut I don't think I ever got the corporate one to work, but I've been authorized to sign the CLA and I believe I have done so. If there is still something missing from my side please let me know. |
|
@ludewigh CLA looks good now. Thanks! |
…12715) * test: add test to verify Vault storage is updated * bug: fix config/rotate-root to store new key * choir: fix changelog name to match PR
…12715) * test: add test to verify Vault storage is updated * bug: fix config/rotate-root to store new key * choir: fix changelog name to match PR
… pair (#12866) * Fix auth/aws so that config/rotate-root saves new key pair to vault (#12715) * test: add test to verify Vault storage is updated * bug: fix config/rotate-root to store new key * choir: fix changelog name to match PR * go get & go mod tidy Co-authored-by: ludewigh <[email protected]>
… pair (#12867) * Fix auth/aws so that config/rotate-root saves new key pair to vault (#12715) * test: add test to verify Vault storage is updated * bug: fix config/rotate-root to store new key * choir: fix changelog name to match PR * go get & go mod tidy * go mod vendor Co-authored-by: ludewigh <[email protected]>
This PR fixes an issue where when calling the endpoint config/rotate-root on auth/aws it would successfully rotate the keys in AWS but not save the updated keys back into vault. After being called once you could no longer authenticate AWS services since the new key was unknown to Vault. The issue was originally reported in #12214